netdev - Re: [PATCH v2] net: 3com: typhoon: fix typhoon_get_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161109.132559.2248490227331285339.davem@davemloft.net>
Date:   Wed, 09 Nov 2016 13:25:59 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     tremyfr@...il.com
Cc:     dave@...dillows.org, sergei.shtylyov@...entembedded.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: 3com: typhoon: fix typhoon_get_link_ksettings

From: Philippe Reynes <tremyfr@...il.com>
Date: Sun,  6 Nov 2016 15:02:32 +0100

> When moving from typhoon_get_settings to typhoon_getlink_ksettings
> in the commit f7a5537cd2a5 ("net: 3com: typhoon: use new api
> ethtool_{get|set}_link_ksettings"), we use a local variable supported
> but we forgot to update the struct ethtool_link_ksettings with
> this value.
> 
> We also initialize advertising to zero, because otherwise it may
> be uninitialized if no case of the switch (tp->xcvr_select) is used.
> 
> Signed-off-by: Philippe Reynes <tremyfr@...il.com>
> ---
> Changelog:
> v2:
> - remove a duplicate "commit" in the commit log

Applied.