netdev - Re: [PATCH net-next] net: core: add missing check for uid_range in rule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161109.132827.579982211587371286.davem@davemloft.net>
Date:   Wed, 09 Nov 2016 13:28:27 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     lorenzo@...gle.com
Cc:     netdev@...r.kernel.org, ek@...gle.com, eric.dumazet@...il.com,
        zenczykowski@...il.com
Subject: Re: [PATCH net-next] net: core: add missing check for uid_range in
 rule_exists.

From: Lorenzo Colitti <lorenzo@...gle.com>
Date: Mon,  7 Nov 2016 00:16:25 +0900

> Without this check, it is not possible to create two rules that
> are identical except for their UID ranges. For example:
> 
> root@...-test:/# ip rule add prio 1000 lookup 300
> root@...-test:/# ip rule add prio 1000 uidrange 100-200 lookup 300
> RTNETLINK answers: File exists
> root@...-test:/# ip rule add prio 1000 uidrange 100-199 lookup 100
> root@...-test:/# ip rule add prio 1000 uidrange 200-299 lookup 200
> root@...-test:/# ip rule add prio 1000 uidrange 300-399 lookup 100
> RTNETLINK answers: File exists
> 
> Tested: https://android-review.googlesource.com/#/c/299980/
> Signed-off-by: Lorenzo Colitti <lorenzo@...gle.com>

Applied.