netdev - Re: [PATCH] net: ipv4: ip_send_unicast_reply should set oif only if it is L3 master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b658cac5-34ab-ac96-4e38-802fa40a3f66@cumulusnetworks.com>
Date:   Wed, 9 Nov 2016 08:52:49 -0700
From:   David Ahern <dsa@...ulusnetworks.com>
To:     Lorenzo Colitti <lorenzo@...gle.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH] net: ipv4: ip_send_unicast_reply should set oif only if
 it is L3 master

On 11/8/16 11:38 PM, Lorenzo Colitti wrote:
> On Wed, Nov 9, 2016 at 7:50 AM, David Ahern <dsa@...ulusnetworks.com> wrote:
>> @@ -1577,7 +1577,8 @@ void ip_send_unicast_reply(struct sock *sk, struct sk_buff *skb,
> 
> Tested-by: Lorenzo Colitti <lorenzo@...gle.com>
> 
> This fixes the IPv4 test, thanks. I notice that 4.8 didn't have
> e0d56fdd73, so if this patch can get into 4.9 then there will be no
> release that had the behaviour change. Not sure if that's possible any
> more though.

This patch is for net so 4.9.

> 
> Can you also fix tcp_v6_send_response, which suffers from the same
> problem? Perhaps revert this hunk of e0d56fdd73 ("net: l3mdev: remove
> redundant calls"):
> 

Let me add it to this patch and re-send.