netdev - Re: [PATCH net-next v2 3/7] vxlan: avoid checking socket multiple times.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161109171625.1212dcb5@griffin>
Date:   Wed, 9 Nov 2016 17:16:25 +0100
From:   Jiri Benc <jbenc@...hat.com>
To:     Pravin B Shelar <pshelar@....org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 3/7] vxlan: avoid checking socket multiple
 times.

On Sat,  5 Nov 2016 11:45:53 -0700, Pravin B Shelar wrote:
> @@ -944,7 +944,9 @@ static bool vxlan_group_used(struct vxlan_net *vn, struct vxlan_dev *dev)
>  {
>  	struct vxlan_dev *vxlan;
>  	struct vxlan_sock *sock4;
> -	struct vxlan_sock *sock6 = NULL;
> +#if IS_ENABLED(CONFIG_IPV6)
> +	struct vxlan_sock *sock6;
> +#endif
>  	unsigned short family = dev->default_dst.remote_ip.sa.sa_family;
>  
>  	sock4 = rtnl_dereference(dev->vn4_sock);

This hunk seems to be unrelated to the rest of the patch (and is
certainly unrelated to the description). Please post it as a standalone
patch.

The rest of the patch looks good.

Thanks,

 Jiri