netdev - Re: [v2] cw1200: Don't leak memory if krealloc failes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161109013700.B3FEE61258@smtp.codeaurora.org>
Date:   Wed,  9 Nov 2016 01:37:00 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Johannes Thumshirn <jthumshirn@...e.de>
Cc:     Solomon Peachy <pizza@...ftnet.org>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Johannes Thumshirn <jthumshirn@...e.de>,
        Johannes Berg <johannes@...solutions.net>
Subject: Re: [v2] cw1200: Don't leak memory if krealloc failes

Johannes Thumshirn <jthumshirn@...e.de> wrote:
> The call to krealloc() in wsm_buf_reserve() directly assigns the newly
> returned memory to buf->begin. This is all fine except when krealloc()
> failes we loose the ability to free the old memory pointed to by
> buf->begin. If we just create a temporary variable to assign memory to
> and assign the memory to it we can mitigate the memory leak.
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@...e.de>
> Cc: Johannes Berg <johannes@...solutions.net>

Patch applied to wireless-drivers-next.git, thanks.

9afdd6128c39 cw1200: Don't leak memory if krealloc failes

-- 
https://patchwork.kernel.org/patch/9358185/

Documentation about submitting wireless patches and checking status
from patchwork:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches