netdev - Re: [PATCH net-next v2 5/7] vxlan: simplify RTF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161109175322.57c9b860@griffin>
Date:   Wed, 9 Nov 2016 17:53:22 +0100
From:   Jiri Benc <jbenc@...hat.com>
To:     Pravin B Shelar <pshelar@....org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 5/7] vxlan: simplify RTF_LOCAL handling.

On Sat,  5 Nov 2016 11:45:55 -0700, Pravin B Shelar wrote:
> +static int check_route_rtf_local(struct sk_buff *skb, struct net_device *dev,
> +				 struct vxlan_dev *vxlan, union vxlan_addr *daddr,
> +				 __be32 dst_port, __be32 vni, struct dst_entry *dst,
> +				 u32 rt_flags)

It's not just checking, it's also bypassing encapsulation if the check
is successful. Would be good to use a name that suggests this effect,
e.g. encap_bypass_if_local (I know, not a nice name) or something.

Thanks,

 Jiri