netdev - Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161109.121844.1246735222647356131.davem@davemloft.net>
Date:   Wed, 09 Nov 2016 12:18:44 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     madalin.bucur@....com
Cc:     netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org, oss@...error.net,
        ppc@...dchasers.com, joe@...ches.com, pebolle@...cali.nl,
        joakim.tjernlund@...nsmode.se
Subject: Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA
 Ethernet

From: Madalin-Cristian Bucur <madalin.bucur@....com>
Date: Wed, 9 Nov 2016 17:16:12 +0000

>> From: Madalin-Cristian Bucur
>> Sent: Monday, November 07, 2016 5:43 PM
>> 
>> > From: David Miller [mailto:davem@...emloft.net]
>> > Sent: Thursday, November 03, 2016 9:58 PM
>> >
>> > From: Madalin Bucur <madalin.bucur@....com>
>> > Date: Wed, 2 Nov 2016 22:17:26 +0200
>> >
>> > > This introduces the Freescale Data Path Acceleration Architecture
> <snip>
> 
>> > > +	int numstats = sizeof(struct rtnl_link_stats64) / sizeof(u64);
>> >  ...
>> > > +		cpustats = (u64 *)&percpu_priv->stats;
>> > > +
>> > > +		for (j = 0; j < numstats; j++)
>> > > +			netstats[j] += cpustats[j];
>> >
>> > This is a memcpy() on well-typed datastructures which requires no
>> > casting or special handling whatsoever, so use memcpy instead of
>> > needlessly open coding the operation.
>> 
>> Will fix.
> 
> Took a second look at this, it's not copying but adding the percpu
> statistics into consolidated results.

Ok, then it looks fine, thanks for clarifying.