netdev - Re: [PATCH v3] xen-netback: prefer xenbus_scanf() over xenbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161109.202452.1499530038072098751.davem@davemloft.net>
Date:   Wed, 09 Nov 2016 20:24:52 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     JBeulich@...e.com
Cc:     paul.durrant@...rix.com, wei.liu2@...rix.com,
        xen-devel@...ts.xenproject.org, netdev@...r.kernel.org
Subject: Re: [PATCH v3] xen-netback: prefer xenbus_scanf() over
 xenbus_gather()

From: "Jan Beulich" <JBeulich@...e.com>
Date: Tue, 08 Nov 2016 00:45:53 -0700

> For single items being collected this should be preferred as being more
> typesafe (as the compiler can check format string and to-be-written-to
> variable match) and more efficient (requiring one less parameter to be
> passed).
> 
> Signed-off-by: Jan Beulich <jbeulich@...e.com>
> ---
> v3: For consistency with other code don't consider zero an error
>     (utilizing that xenbus_scanf() at present won't return zero).
> v2: Avoid commit message to continue from subject.

Applied to net-next, thanks.