netdev - Re: [PATCH net-next v2 3/7] vxlan: avoid checking socket multiple times.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOrHB_DB8pEiQ-TfPYqUrNpq=p54umW3=pbE6kUmj_=oZogPpQ@mail.gmail.com>
Date:   Wed, 9 Nov 2016 19:33:31 -0800
From:   Pravin Shelar <pshelar@....org>
To:     Jiri Benc <jbenc@...hat.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 3/7] vxlan: avoid checking socket multiple times.

On Wed, Nov 9, 2016 at 8:34 AM, Jiri Benc <jbenc@...hat.com> wrote:
> On Sat,  5 Nov 2016 11:45:53 -0700, Pravin B Shelar wrote:
>> @@ -2070,11 +2072,9 @@ static void vxlan_xmit_one(struct sk_buff *skb, struct net_device *dev,
>>               struct dst_entry *ndst;
>>               u32 rt6i_flags;
>>
>> -             if (!sock6)
>> -                     goto drop;
>>               sk = sock6->sock->sk;
>
> I take back that the rest of the patch looks good. This will panic if
> an IPv6 packet is routed (through encap route) to an IPv4-only
> interface.
>

Actually this is fixed in later patch. But I will fix this patch too.

Thanks for review.