netdev - Re: [PATCHv2 net] igmp: do not remove igmp souce list info when set link down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161112.232935.1582203391859033298.davem@davemloft.net>
Date:   Sat, 12 Nov 2016 23:29:35 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     liuhangbin@...il.com
Cc:     netdev@...r.kernel.org, hannes@...essinduktion.org,
        daniel@...earbox.net
Subject: Re: [PATCHv2 net] igmp: do not remove igmp souce list info when
 set link down

From: Hangbin Liu <liuhangbin@...il.com>
Date: Wed,  9 Nov 2016 11:16:40 +0800

> In commit 24cf3af(igmp: call ip_mc_clear_src...), we forgot to remove
> igmpv3_clear_delrec() in ip_mc_down(), which also called ip_mc_clear_src().
> This make us clear all IGMPv3 source filter info after NETDEV_DOWN.
> Move igmpv3_clear_delrec() to ip_mc_destroy_dev() and then no need
> ip_mc_clear_src() in ip_mc_destroy_dev().
> 
> On the other hand, we should restore back instead of free all source filter
> info in igmpv3_del_delrec(). Or we will not able to restore IGMPv3 source
> filter info after NETDEV_UP and NETDEV_POST_TYPE_CHANGE.
> 
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

Commits must be referenced with 12 characters of significance in the
SHA1-ID and appear in an appropriately formed "Fixes: " tag right
before the signoffs.

As-per Documentation/SubmittingPatches.

It also doesn't look so good how you lack a space between the SHA1-ID
and the commit message header text reference.