netdev - Re: [PATCH net] net: __skb_flow_dissect() must cap its return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161112.234232.1152946645540246281.davem@davemloft.net>
Date:   Sat, 12 Nov 2016 23:42:32 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     yibyang@...co.com, tom@...bertland.com, jojvargh@...co.com,
        alexander.h.duyck@...el.com, ast@...nel.org, willemb@...gle.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] net: __skb_flow_dissect() must cap its return value

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 09 Nov 2016 16:04:46 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> After Tom patch, thoff field could point past the end of the buffer,
> this could fool some callers.
> 
> If an skb was provided, skb->len should be the upper limit.
> If not, hlen is supposed to be the upper limit.
> 
> Fixes: a6e544b0a88b ("flow_dissector: Jump to exit code in __skb_flow_dissect")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Yibin Yang <yibyang@...co.com
> Acked-by: Alexander Duyck <alexander.h.duyck@...el.com>
> Acked-by: Willem de Bruijn <willemb@...gle.com>
> Acked-by: Alexei Starovoitov <ast@...nel.org>

Applied and queued up for -stable, thanks Eric.