netdev - Re: [PATCH] netfilter: x_tables: simplify IS_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161113212707.GA30418@salvia>
Date:   Sun, 13 Nov 2016 22:27:07 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Julia Lawall <Julia.Lawall@...6.fr>
Cc:     Florian Westphal <fw@...len.de>,
        "David S. Miller" <davem@...emloft.net>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, coreteam@...filter.org,
        netfilter-devel@...r.kernel.org,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        James Morris <jmorris@...ei.org>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        Patrick McHardy <kaber@...sh.net>,
        christophe.jaillet@...adoo.fr
Subject: Re: [PATCH] netfilter: x_tables: simplify IS_ERR_OR_NULL to NULL test

On Fri, Nov 11, 2016 at 01:32:38PM +0100, Julia Lawall wrote:
> Since commit 7926dbfa4bc1 ("netfilter: don't use
> mutex_lock_interruptible()"), the function xt_find_table_lock can only
> return NULL on an error.  Simplify the call sites and update the
> comment before the function.

Applied, thanks Julia!