netdev - Re: [PATCH] [v2] net: phy: phy drivers should not set SUPPORTED_[Asym

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161114.131225.1515538193536426496.davem@davemloft.net>
Date:   Mon, 14 Nov 2016 13:12:25 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     timur@...eaurora.org
Cc:     f.fainelli@...il.com, jon.mason@...adcom.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH] [v2] net: phy: phy drivers should not set
 SUPPORTED_[Asym_]Pause

From: Timur Tabi <timur@...eaurora.org>
Date: Thu, 10 Nov 2016 17:46:01 -0600

> Instead of having individual PHY drivers set the SUPPORTED_Pause and
> SUPPORTED_Asym_Pause flags, phylib itself should set those flags.
> During autonegotiation, the PHYs will determine whether to enable
> pause frame support.
> 
> Pause frames are a feature that is supported by the MAC.  It is the MAC
> that generates the frames and that processes them.  The PHY can only be
> configured to allow them to pass through.
> 
> So the new process is:
 ...
> Signed-off-by: Timur Tabi <timur@...eaurora.org>
> ---
> 
> v2: set the Pause bits in phy_probe()
>     update broadcom.c which was recently changed

Florian please review this patch.

Thank you.