netdev - Re: linux-next: BUG: unable to handle kernel NULL pointer dereference in __sk_mem_raise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1479167355.8455.93.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Mon, 14 Nov 2016 15:49:15 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Andrei Vagin <avagin@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: linux-next: BUG: unable to handle kernel NULL pointer
 dereference in __sk_mem_raise_allocated()

On Mon, 2016-11-14 at 15:35 -0800, Eric Dumazet wrote:

> 
> Thanks for the report.
> 
> I guess following patch would be needed ?
> 
> diff --git a/net/ipv4/udplite.c b/net/ipv4/udplite.c
> index af817158d830c0da080935ba29e012dffbb89112..12604c0371c451efcc9aad278bb86be9ac4bb813 100644
> --- a/net/ipv4/udplite.c
> +++ b/net/ipv4/udplite.c
> @@ -54,6 +54,7 @@ struct proto 	udplite_prot = {
>  	.hash		   = udp_lib_hash,
>  	.unhash		   = udp_lib_unhash,
>  	.get_port	   = udp_v4_get_port,
> +	.memory_allocated  = &udp_memory_allocated,
>  	.obj_size	   = sizeof(struct udp_sock),
>  	.h.udp_table	   = &udplite_table,
>  #ifdef CONFIG_COMPAT
> diff --git a/net/ipv6/udplite.c b/net/ipv6/udplite.c
> index 47d0d2b87106558fece3496479198005c55b99e7..946025c888cc9519fb3523edbbe8afbb18273326 100644
> --- a/net/ipv6/udplite.c
> +++ b/net/ipv6/udplite.c
> @@ -49,6 +49,7 @@ struct proto udplitev6_prot = {
>  	.hash		   = udp_lib_hash,
>  	.unhash		   = udp_lib_unhash,
>  	.get_port	   = udp_v6_get_port,
> +	.memory_allocated  = &udp_memory_allocated,
>  	.obj_size	   = sizeof(struct udp6_sock),
>  	.h.udp_table	   = &udplite_table,
>  #ifdef CONFIG_COMPAT
> 

.sysctl_mem also needs to be set.