netdev - RE: [PATCH v3 3/5] net: asix: Fix AX88772x resume failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00e501d23e54$337d4b70$9a77e250$@asix.com.tw>
Date:   Mon, 14 Nov 2016 16:50:44 +0800
From:   "ASIX_Allan [Home]" <allan@...x.com.tw>
To:     "'Jon Hunter'" <jonathanh@...dia.com>, <robert.foss@...labora.com>,
        <freddy@...x.com.tw>, <Dean_Jenkins@...tor.com>,
        <Mark_Craske@...tor.com>, <davem@...emloft.net>,
        <ivecera@...hat.com>, <john.stultz@...aro.org>,
        <vpalatin@...omium.org>, <stephen@...workplumber.org>,
        <grundler@...omium.org>, <changchias@...il.com>, <andrew@...n.ch>,
        <tremyfr@...il.com>, <colin.king@...onical.com>,
        <linux-usb@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <vpalatin@...gle.com>
Subject: RE: [PATCH v3 3/5] net: asix: Fix AX88772x resume failures

Hi Jon,

It seems the AX88772x dongle had been unexpectedly removed while running the
ax88772_suspend() routine. If yes, you might see these error messages
because the hardware had been absent.    

---
Best regards,
Allan Chou


-----Original Message-----
From: Jon Hunter [mailto:jonathanh@...dia.com] 
Sent: Thursday, November 10, 2016 8:01 PM
To: robert.foss@...labora.com; freddy@...x.com.tw; Dean_Jenkins@...tor.com;
Mark_Craske@...tor.com; davem@...emloft.net; ivecera@...hat.com;
john.stultz@...aro.org; vpalatin@...omium.org; stephen@...workplumber.org;
grundler@...omium.org; changchias@...il.com; allan@...x.com.tw;
andrew@...n.ch; tremyfr@...il.com; colin.king@...onical.com;
linux-usb@...r.kernel.org; netdev@...r.kernel.org;
linux-kernel@...r.kernel.org; vpalatin@...gle.com
Subject: Re: [PATCH v3 3/5] net: asix: Fix AX88772x resume failures

Hi Robert,

On 29/08/16 14:32, robert.foss@...labora.com wrote:
> From: Robert Foss <robert.foss@...labora.com>
> 
> From: Allan Chou <allan@...x.com.tw>
> 
> The change fixes AX88772x resume failure by
> - Restore incorrect AX88772A PHY registers when resetting
> - Need to stop MAC operation when suspending
> - Need to restart MII when restoring PHY
> 
> Signed-off-by: Allan Chou <allan@...x.com.tw>
> Signed-off-by: Robert Foss <robert.foss@...labora.com>
> Tested-by: Robert Foss <robert.foss@...labora.com>

After this commit, I have started seeing the following messages during
system suspend on various tegra boards using asix ethernet dongles ...

[  288.667010] PM: Syncing filesystems ... done.
[  288.672223] Freezing user space processes ... (elapsed 0.001 seconds)
done.
[  288.680505] Double checking all user space processes after OOM killer
disable... (elapsed 0.000 seconds) [  288.690193] Freezing remaining
freezable tasks ... (elapsed 0.001 seconds) done.
[  288.698987] Suspending console(s) (use no_console_suspend to debug) [
288.706605] asix 1-1:1.0 eth0: Failed to read reg index 0x0000: -19 [
288.706613] asix 1-1:1.0 eth0: Error reading Medium Status register:
ffffffed [  288.706621] asix 1-1:1.0 eth0: Failed to write reg index 0x0000:
-19 [  288.706629] asix 1-1:1.0 eth0: Failed to write Medium Mode mode to
0xfeed: ffffffed [  288.759167] PM: suspend of devices complete after 52.772
msecs

Interestingly, it only seems to happen if the ethernet is in a disconnected
state when entering suspend. I have not had chance to look at this any
further, but wanted to see if you had any thoughts.

Cheers
Jon

--
nvpublic