netdev - Re: [PATCH] amd-xgbe: fix unsigned comparison against less than zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9b6547cf-a37e-e7b2-d725-4bccc1fb2dfc@amd.com>
Date:   Tue, 15 Nov 2016 08:09:06 -0600
From:   Tom Lendacky <thomas.lendacky@....com>
To:     Colin King <colin.king@...onical.com>, <netdev@...r.kernel.org>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] amd-xgbe: fix unsigned comparison against less than zero

On 11/15/2016 6:18 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Comparing unsigned int ret to less than zero for an error status
> check is never true.  Fix this by making ret a signed int. Reduce
> scope of ret too.
> 
> Found with static analysis by CoverityScan, CID 1377750

Thanks Colin, this was already identified by someone else and I
submitted the patch yesterday.

Thanks,
Tom

> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c
> index 4ba4332..168507e 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c
> @@ -2346,7 +2346,7 @@ static bool xgbe_phy_valid_speed(struct xgbe_prv_data *pdata, int speed)
>  static int xgbe_phy_link_status(struct xgbe_prv_data *pdata, int *an_restart)
>  {
>  	struct xgbe_phy_data *phy_data = pdata->phy_data;
> -	unsigned int ret, reg;
> +	unsigned int reg;
>  
>  	*an_restart = 0;
>  
> @@ -2365,7 +2365,8 @@ static int xgbe_phy_link_status(struct xgbe_prv_data *pdata, int *an_restart)
>  
>  	if (phy_data->phydev) {
>  		/* Check external PHY */
> -		ret = phy_read_status(phy_data->phydev);
> +		int ret = phy_read_status(phy_data->phydev);
> +
>  		if (ret < 0)
>  			return 0;
>  
>