netdev - Re: [PATCH net] udp: restore UDPlite many-cast delivery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1479170606.8455.112.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Mon, 14 Nov 2016 16:43:26 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Pablo Neira Ayuso <pablo@...filter.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        drheld@...gle.com
Subject: Re: [PATCH net] udp: restore UDPlite many-cast delivery

On Mon, 2016-11-14 at 23:40 +0100, Pablo Neira Ayuso wrote:
> Honor udptable parameter that is passed to __udp*_lib_mcast_deliver(),
> otherwise udplite broadcast/multicast use the wrong table and it breaks.
> 
> Fixes: 2dc41cff7545 ("udp: Use hash2 for long hash1 chains in __udp*_lib_mcast_deliver.")
> Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>
> ---
> It looks like UDPlite accidentally broke when dealing with long UDP many-cast
> chains, give the wrong table is used for udplite. Compile tested only.

Good catch. Looks like some people actually use UDPlite ;)

Acked-by: Eric Dumazet <edumazet@...gle.com>

Thanks Pablo.