netdev - Re: [PATCH v2] net: ethernet: faraday: To support device tree usage.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161116135329.GG19962@lunn.ch>
Date:   Wed, 16 Nov 2016 14:53:29 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Greentime Hu <green.hu@...il.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        jiri@...nulli.us
Subject: Re: [PATCH v2] net: ethernet: faraday: To support device tree usage.

On Wed, Nov 16, 2016 at 08:03:46PM +0800, Greentime Hu wrote:
> Signed-off-by: Greentime Hu <green.hu@...il.com>
> ---
>  drivers/net/ethernet/faraday/ftmac100.c |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/net/ethernet/faraday/ftmac100.c b/drivers/net/ethernet/faraday/ftmac100.c
> index dce5f7b..5d70ee9 100644
> --- a/drivers/net/ethernet/faraday/ftmac100.c
> +++ b/drivers/net/ethernet/faraday/ftmac100.c
> @@ -1172,11 +1172,17 @@ static int __exit ftmac100_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +static const struct of_device_id ftmac100_of_ids[] = {
> +	{ .compatible = "andestech,atmac100" },

Please see my comment to v1.

You are also supposed to add a binding document.

    Andrew