netdev - Aw: [PATCH 1/1] ixgbe: write flush vfta registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Nov 2016 15:05:44 +0100
From:   "Lino Sanfilippo" <LinoSanfilippo@....de>
To:     zyjzyj2000@...il.com
Cc:     e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org,
        jeffrey.t.kirsher@...el.com, intel-wired-lan@...ts.osuosl.org,
        "Zhu Yanjun" <zyjzyj2000@...il.com>
Subject: Aw: [PATCH 1/1] ixgbe: write flush vfta registers



Hi,

> 
> Sometimes vfta registers can not be written successfully in dcb mode.
> This is very occassional. When the ixgbe nic runs for a very long time,
> sometimes this bug occurs. But after IXGBE_WRITE_FLUSH is executed,
> this bug never occurs.
> 
> Signed-off-by: Zhu Yanjun <zyjzyj2000@...il.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> index bd93d82..1221cfb 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> @@ -4138,8 +4138,10 @@ static void ixgbe_vlan_promisc_enable(struct ixgbe_adapter *adapter)
>  	}
>  
>  	/* Set all bits in the VLAN filter table array */
> -	for (i = hw->mac.vft_size; i--;)
> +	for (i = hw->mac.vft_size; i--;) {
>  		IXGBE_WRITE_REG(hw, IXGBE_VFTA(i), ~0U);
> +		IXGBE_WRITE_FLUSH(hw);
> +	}

Should it not be sufficient to do the flush only once, at the end of the function?

Regards,
Lino