netdev - Re: [PATCH] netronome: don't access real_num_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJpBn1wOyv3G0+3yKoZD4CSTedgQn9TZPygP97539fHYY+rt3A@mail.gmail.com>
Date:   Wed, 16 Nov 2016 08:37:06 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     "David S. Miller" <davem@...emloft.net>, oss-drivers@...ronome.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH] netronome: don't access real_num_rx_queues directly

On Wed, Nov 16, 2016 at 6:10 AM, Arnd Bergmann <arnd@...db.de> wrote:
> The netdev->real_num_rx_queues setting is only available if CONFIG_SYSFS
> is enabled, so we now get a build failure when that is turned off:
>
> netronome/nfp/nfp_net_common.c: In function 'nfp_net_ring_swap_enable':
> netronome/nfp/nfp_net_common.c:2489:18: error: 'struct net_device' has no member named 'real_num_rx_queues'; did you mean 'real_num_tx_queues'?
>
> As far as I can tell, the check here is only used as an optimization that
> we can skip in order to fix the compilation. If sysfs is disabled,
> the following netif_set_real_num_rx_queues() has no effect.
>
> Fixes: 164d1e9e5d52 ("nfp: add support for ethtool .set_channels")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Thanks Arnd!  This is needed in net-next only.