netdev - Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87shqrmf1h.fsf@kamboji.qca.qualcomm.com>
Date:   Wed, 16 Nov 2016 18:54:22 +0000
From:   "Valo, Kalle" <kvalo@....qualcomm.com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
CC:     "k.eugene.e@...il.com" <k.eugene.e@...il.com>,
        Andy Gross <andy.gross@...aro.org>,
        "wcn36xx@...ts.infradead.org" <wcn36xx@...ts.infradead.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>
Subject: Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()

Kalle Valo <kvalo@....qualcomm.com> writes:

> Bjorn Andersson <bjorn.andersson@...aro.org> wrote:
>> The correct include file for getting errno constants and ERR_PTR() is
>> linux/err.h, rather than linux/errno.h, so fix the include.
>> 
>> Fixes: e8b123e60084 ("soc: qcom: smem_state: Add stubs for disabled smem_state")
>> Acked-by: Andy Gross <andy.gross@...aro.org>
>> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
>
> For some reason this fails to compile now. Can you take a look, please?
>
> ERROR: "qcom_wcnss_open_channel" [drivers/net/wireless/ath/wcn36xx/wcn36xx.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
>
> 5 patches set to Changes Requested.
>
> 9429045 [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()
> 9429047 [v5,2/5] wcn36xx: Transition driver to SMD client
> 9429037 [v5,3/5] wcn36xx: Implement firmware assisted scan
> 9429043 [v5,4/5] wcn36xx: Implement print_reg indication
> 9429023 [v5,5/5] wcn36xx: Don't use the destroyed hal_mutex

The linking problem seems to start with patch 2. I have attached the
.config file I use.

-- 
Kalle Valo


View attachment "ATT55264.config" of type "text/plain" (142424 bytes)