netdev - Re: [PATCH net] cxgb4: do not call napi_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161116.170708.2003021089286447218.davem@davemloft.net>
Date:   Wed, 16 Nov 2016 17:07:08 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, hariprasad@...lsio.com
Subject: Re: [PATCH net] cxgb4: do not call napi_hash_del()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 16 Nov 2016 06:19:02 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Calling napi_hash_del() before netif_napi_del() is dangerous
> if a synchronize_rcu() is not enforced before NAPI struct freeing.
> 
> Lets leave this detail to core networking stack and feel
> more comfortable.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.