lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 15 Nov 2016 22:12:17 -0500 (EST) From: David Miller <davem@...emloft.net> To: alex.g@...ptrum.com Cc: f.fainelli@...il.com, gokhan@...ptrum.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed From: Alex <alex.g@...ptrum.com> Date: Mon, 14 Nov 2016 13:54:57 -0800 > > > On 11/14/2016 01:25 PM, Florian Fainelli wrote: >> On 11/14/2016 01:18 PM, David Miller wrote: >>> From: Alexandru Gagniuc <alex.g@...ptrum.com> >>> Date: Sat, 12 Nov 2016 15:32:13 -0800 >>> >>>> + if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) >>>> + ret = vsc8601_add_skew(phydev); >>> >>> I think you should use phy_interface_is_rgmii() here. >>> >> >> This would include all RGMII modes, here I think the intent is to >> check >> for PHY_INTERFACE_MODE_RGMII_ID and PHY_INTERFACE_MODE_RGMII_TXID (or >> RXID), > > That is correct. > >> Alexandru, what direction does the skew settings apply to? > > It applies a skew in both TX and RX directions. Please repost your patch, making the intent clear either in the commit message or a code comment. Thanks.
Powered by blists - more mailing lists