netdev - Re: [PATCH] net: ioctl SIOCSIFADDR minor cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161115.223111.734917440131578613.davem@davemloft.net>
Date:   Tue, 15 Nov 2016 22:31:11 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     Linyu.Yuan@...atel-sbell.com.cn
Cc:     cugyly@....com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: ioctl SIOCSIFADDR minor cleanup

From: YUAN Linyu <Linyu.Yuan@...atel-sbell.com.cn>
Date: Wed, 16 Nov 2016 03:13:31 +0000

> So assign label to request name will do same thing as original code.

Nope.  dev->name does not have the colon, it was trimmed from the
string for the device lookup.  So the found device's dev->name does
not have the colon character, even if it was in ifr.ifr_name

This was my entire point.

You are changing the behvaior of the code in an invalid way.