netdev - Re: [PATCH net] rtnetlink: fix rtnl_vfinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161115.224252.570438889473921203.davem@davemloft.net>
Date:   Tue, 15 Nov 2016 22:42:52 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     sd@...asysnail.net
Cc:     netdev@...r.kernel.org, eranbe@...lanox.com, hadarh@...lanox.com,
        ogerlitz@...lanox.com, sucheta.chakraborty@...gic.com
Subject: Re: [PATCH net] rtnetlink: fix rtnl_vfinfo_size

From: Sabrina Dubroca <sd@...asysnail.net>
Date: Tue, 15 Nov 2016 10:39:03 +0100

> The size reported by rtnl_vfinfo_size doesn't match the space used by
> rtnl_fill_vfinfo.
> 
> rtnl_vfinfo_size currently doesn't account for the nest attributes
> used by statistics (added in commit 3b766cd83232), nor for struct
> ifla_vf_tx_rate (since commit ed616689a3d9, which added ifla_vf_rate
> to the dump without removing ifla_vf_tx_rate, but replaced
> ifla_vf_tx_rate with ifla_vf_rate in the size computation).
> 
> Fixes: 3b766cd83232 ("net/core: Add reading VF statistics through the PF netdevice")
> Fixes: ed616689a3d9 ("net-next:v4: Add support to configure SR-IOV VF minimum and maximum Tx rate through ip tool")
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>

Applied and queued up for -stable.