netdev - Re: [PATCH net-next] net/mlx4_en: remove napi_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161117.111737.2006621470541369678.davem@davemloft.net>
Date:   Thu, 17 Nov 2016 11:17:37 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, tariqt@...lanox.com
Subject: Re: [PATCH net-next] net/mlx4_en: remove napi_hash_del() call

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 16 Nov 2016 05:49:22 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> There is no need calling napi_hash_del()+synchronize_rcu() before
> calling netif_napi_del()
> 
> netif_napi_del() does this already.
> 
> Using napi_hash_del() in a driver is useful only when dealing with
> a batch of NAPI structures, so that a single synchronize_rcu() can
> be used. mlx4_en_deactivate_cq() is deactivating a single NAPI.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.