netdev - Re: [PATCH net-next 1/4] geneve: Unify LWT and netdev handling.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201611181659.o9qkaxCU%fengguang.wu@intel.com>
Date:   Fri, 18 Nov 2016 16:40:51 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Pravin B Shelar <pshelar@....org>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        Pravin B Shelar <pshelar@....org>
Subject: Re: [PATCH net-next 1/4] geneve: Unify LWT and netdev handling.

Hi Pravin,

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Pravin-B-Shelar/geneve-Use-LWT-more-effectively/20161118-151426
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/net/geneve.c: In function 'geneve_xmit':
>> drivers/net/geneve.c:942:10: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized]
     else if (err == -ENETUNREACH)
             ^

vim +/err +942 drivers/net/geneve.c

8ed66f0e John W. Linville 2015-10-26  926  	}
8eb3b995 Daniel Borkmann  2016-03-09  927  
e6efd144 Pravin B Shelar  2016-11-17  928  #if IS_ENABLED(CONFIG_IPV6)
e6efd144 Pravin B Shelar  2016-11-17  929  	if (info->mode & IP_TUNNEL_INFO_IPV6)
e6efd144 Pravin B Shelar  2016-11-17  930  		err = geneve6_xmit_skb(skb, dev, geneve, info);
e6efd144 Pravin B Shelar  2016-11-17  931  	else
e6efd144 Pravin B Shelar  2016-11-17  932  #endif
e6efd144 Pravin B Shelar  2016-11-17  933  		err = geneve_xmit_skb(skb, dev, geneve, info);
8ed66f0e John W. Linville 2015-10-26  934  
e6efd144 Pravin B Shelar  2016-11-17  935  	if (likely(!err))
e6efd144 Pravin B Shelar  2016-11-17  936  		return NETDEV_TX_OK;
8ed66f0e John W. Linville 2015-10-26  937  tx_error:
8ed66f0e John W. Linville 2015-10-26  938  	dev_kfree_skb(skb);
aed069df Alexander Duyck  2016-04-14  939  
8ed66f0e John W. Linville 2015-10-26  940  	if (err == -ELOOP)
8ed66f0e John W. Linville 2015-10-26  941  		dev->stats.collisions++;
8ed66f0e John W. Linville 2015-10-26 @942  	else if (err == -ENETUNREACH)
8ed66f0e John W. Linville 2015-10-26  943  		dev->stats.tx_carrier_errors++;
efeb2267 Haishuang Yan    2016-06-21  944  
8ed66f0e John W. Linville 2015-10-26  945  	dev->stats.tx_errors++;
8ed66f0e John W. Linville 2015-10-26  946  	return NETDEV_TX_OK;
8ed66f0e John W. Linville 2015-10-26  947  }
8ed66f0e John W. Linville 2015-10-26  948  
91572088 Jarod Wilson     2016-10-20  949  static int geneve_change_mtu(struct net_device *dev, int new_mtu)
55e5bfb5 David Wragg      2016-02-10  950  {

:::::: The code at line 942 was first introduced by commit
:::::: 8ed66f0e8235118a31720acdab3bbbe9debd0f6a geneve: implement support for IPv6-based tunnels

:::::: TO: John W. Linville <linville@...driver.com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (56934 bytes)