netdev - Re: [PATCH net-next v3 4/7] vxlan: improve vxlan route lookup checks.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOrHB_BNei3ZKAmbNWNRvYVnb3ySKKn4nncZRqr8RoANbBp1DQ@mail.gmail.com>
Date:   Thu, 17 Nov 2016 21:30:37 -0800
From:   Pravin Shelar <pshelar@....org>
To:     David Laight <David.Laight@...lab.com>
Cc:     Jiri Benc <jbenc@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v3 4/7] vxlan: improve vxlan route lookup checks.

On Thu, Nov 17, 2016 at 2:17 AM, David Laight <David.Laight@...lab.com> wrote:
> From: Of Jiri Benc
>> Sent: 15 November 2016 14:40
>> On Sun, 13 Nov 2016 20:43:55 -0800, Pravin B Shelar wrote:
>> > @@ -1929,8 +1951,8 @@ static void vxlan_xmit_one(struct sk_buff *skb, struct net_device *dev,
>> >     union vxlan_addr *src;
>> >     struct vxlan_metadata _md;
>> >     struct vxlan_metadata *md = &_md;
>> > -   struct dst_entry *ndst = NULL;
>> >     __be16 src_port = 0, dst_port;
>> > +   struct dst_entry *ndst = NULL;
>> >     __be32 vni, label;
>> >     __be16 df = 0;
>> >     __u8 tos, ttl;
>>
>> This looks kind of arbitrary. You might want to remove this hunk or
>> merge it to patch 3.
>
> Worse than arbitrary, it adds 4 bytes of pad on 64bit systems.
>
OK. I will send out a patch.
But this is not real issue in vxlan module today ;)