[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20161119.221154.342519376993786527.davem@davemloft.net>
Date: Sat, 19 Nov 2016 22:11:54 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: adobriyan@...il.com
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH] netlink: use "unsigned int" in nla_next()
From: Alexey Dobriyan <adobriyan@...il.com>
Date: Sat, 19 Nov 2016 03:54:35 +0300
> ->nla_len is unsigned entity (it's length after all) and u16,
> thus it can't overflow when being aligned into int/unsigned int.
>
> (nlmsg_next has the same code, but I didn't yet convince myself
> it is correct to do so).
>
> There is pointer arithmetic in this function and offset being
> unsigned is better:
...
> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
Applied to net-next.
Powered by blists - more mailing lists