netdev - Re: [PATCH net-next] udp: avoid one cache line miss in recvmsg()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1479765680.8455.422.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Mon, 21 Nov 2016 14:01:20 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] udp: avoid one cache line miss in recvmsg()

On Mon, 2016-11-21 at 22:36 +0100, Paolo Abeni wrote:

> Nice catch, thank you Eric!
> 
> This gives up to 8% speed-up in my performance test (wire speed udp flood
> with small packets)
> 
> Tested-by: Paolo Abeni <pabeni@...hat.com>

Thanks Paolo

Note that udp6_recvmsg() hits the 3rd cache line of skb to access
skb->protocol :

is_udp4 = (skb->protocol == htons(ETH_P_IP));

We might some trick to avoid this cache line miss.