netdev - RE: [PATCH iproute2 2/2] tc/act_tunnel: Introduce ip tunnel action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9B0331B6EBBD0E4684FBFAEDA55776F93D345ED8@HASMSX110.ger.corp.intel.com>
Date:   Mon, 21 Nov 2016 23:50:03 +0000
From:   "Rosen, Rami" <rami.rosen@...el.com>
To:     Amir Vadai <amir@...ai.me>,
        Stephen Hemminger <stephen@...workplumber.org>
CC:     "David S. Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Or Gerlitz <ogerlitz@...lanox.com>,
        Hadar Har-Zion <hadarh@...lanox.com>,
        Roi Dayan <roid@...lanox.com>
Subject: RE: [PATCH iproute2 2/2] tc/act_tunnel: Introduce ip tunnel action

Hi, Amir,

Following are three minor comments:

Seems that TCA_TUNNEL_KEY_PAD used anywhere:
 
+	TCA_TUNNEL_KEY_PAD,
+	__TCA_TUNNEL_KEY_MAX,
+};


Should be "and destination IP 11.11.0.2" instead of  "and destination IP 11.11.0.1":

+Tunnel ID (for example VNI in VXLAN tunnel) .TP .B src_ip Outer header 
+source IP address (IPv4 or IPv6) .TP .B dst_ip Outer header destination 
+IP address (IPv4 or IPv6) .RE .SH EXAMPLES The following example 
+encapsulates incoming ICMP packets on eth0 into a vxlan tunnel by 
+setting metadata to VNI 11, source IP 11.11.0.1 and destination IP
+11.11.0.1 by forwarding the skb with the metadata to device vxlan0, 
+which will prepare the VXLAN headers:
+
+.RS
+.EX
+#tc qdisc add dev eth0 handle ffff: ingress #tc filter add dev eth0 
+protocol ip parent ffff: \\
+  flower \\
+    ip_proto icmp \\
+  action tunnel_key set \\
+    src_ip 11.11.0.1 \\
+    dst_ip 11.11.0.2 \\
+    id 11 \\


Typo: should be "ip tunnel" instead of "ip tunel":

+ * m_tunnel_key.c	ip tunel manipulation module
+ *
+ *              This program is free software; you can redistribute it and/or

Keep on the good work!

Regards,
Rami Rosen
Intel Corporation