netdev - ip -s macsec show: Statistics for OutOctets... and OutPkts... switched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF4B44CECE.BF9C7A12-ONC1258072.0037C56C-C1258072.003F5731@continental-corporation.com>
Date:   Mon, 21 Nov 2016 12:31:50 +0100
From:   Daniel.Hopf@...tinental-corporation.com
To:     netdev@...r.kernel.org
Subject: ip -s macsec show: Statistics for OutOctets... and OutPkts... switched

Dear community,

I'm using the following ip utility:

ubuntu2@...ntu2:~$ ip -V
ip utility, iproute2-ss161009
ubuntu2@...ntu2:~$ uname -r
4.8.0-22-generic

During tests with the recent MACsec implementation I noticed that the 
statistics for OutOctets[Protected|Encrypted] and 
OutPkts[Protected|Encrypted] are switched.

The error seems to reside in lines 637:640 of iproute2/ip/ipmacsec.c:
        [MACSEC_TXSC_STATS_ATTR_OUT_PKTS_PROTECTED] = 
"OutOctetsProtected",
        [MACSEC_TXSC_STATS_ATTR_OUT_PKTS_ENCRYPTED] = 
"OutOctetsEncrypted",
        [MACSEC_TXSC_STATS_ATTR_OUT_OCTETS_PROTECTED] = 
"OutPktsProtected",
        [MACSEC_TXSC_STATS_ATTR_OUT_OCTETS_ENCRYPTED] = 
"OutPktsEncrypted",

In my opinion this should instead read:
        [MACSEC_TXSC_STATS_ATTR_OUT_PKTS_PROTECTED] = "OutPktsProtected",
        [MACSEC_TXSC_STATS_ATTR_OUT_PKTS_ENCRYPTED] = "OutPktsEncrypted",
        [MACSEC_TXSC_STATS_ATTR_OUT_OCTETS_PROTECTED] = 
"OutOctetsProtected",
        [MACSEC_TXSC_STATS_ATTR_OUT_OCTETS_ENCRYPTED] = 
"OutOctetsEncrypted",

Regards
- Daniel