lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CA+6hz4pFLqs_BgUvkbf3B5dG3yR=8QTLgVZjyTm2oaaPN=QOZg@mail.gmail.com> Date: Mon, 21 Nov 2016 08:52:45 +0800 From: Feng Gao <gfree.wind@...il.com> To: "David S. Miller" <davem@...emloft.net>, Patrick McHardy <kaber@...sh.net>, Linux Kernel Network Developers <netdev@...r.kernel.org>, Feng Gao <gfree.wind@...il.com> Subject: Re: [PATCH net-next 1/1] driver: macvlan: Remove duplicated IFF_UP condition check in macvlan_forward_source On Mon, Nov 21, 2016 at 8:26 AM, <fgao@...ai8.com> wrote: > From: Gao Feng <gfree.wind@...il.com> > > The function macvlan_forward_source_one has already checked the flag > IFF_UP, so needn't check it outside in macvlan_forward_source too. > > Signed-off-by: Gao Feng <gfree.wind@...il.com> > --- > v2: Remove the IFF_UP check in macvlan_forward_source instead of macvlan_forward_source_one > v1: Initial patch > > drivers/net/macvlan.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c > index 13b7e0b..7ddfd2c 100644 > --- a/drivers/net/macvlan.c > +++ b/drivers/net/macvlan.c > @@ -400,8 +400,7 @@ static void macvlan_forward_source(struct sk_buff *skb, > > hlist_for_each_entry_rcu(entry, h, hlist) { > if (ether_addr_equal_64bits(entry->addr, addr)) > - if (entry->vlan->dev->flags & IFF_UP) > - macvlan_forward_source_one(skb, entry->vlan); > + macvlan_forward_source_one(skb, entry->vlan); > } > } > > -- > 1.9.1 > > Sorry, I forget add the "v2" in the title. Regards Feng
Powered by blists - more mailing lists