netdev - Re: [PATCH] VSOCK: add loopback to virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161121134053.GE15478@stefanha-x1.localdomain>
Date:   Mon, 21 Nov 2016 13:40:53 +0000
From:   Stefan Hajnoczi <stefanha@...hat.com>
To:     David Miller <davem@...emloft.net>
Cc:     john.fastabend@...il.com, netdev@...r.kernel.org,
        cavery@...hat.com, imbrenda@...ux.vnet.ibm.com, jhansen@...are.com
Subject: Re: [PATCH] VSOCK: add loopback to virtio_transport

On Sat, Nov 19, 2016 at 10:16:43PM -0500, David Miller wrote:
> From: John Fastabend <john.fastabend@...il.com>
> Date: Sat, 19 Nov 2016 19:14:15 -0800
> 
> > On 16-11-19 07:08 PM, David Miller wrote:
> >> From: Stefan Hajnoczi <stefanha@...hat.com>
> >> Date: Thu, 17 Nov 2016 15:49:23 +0000
> >> 
> >>> @@ -159,6 +199,10 @@ virtio_transport_send_pkt(struct virtio_vsock_pkt *pkt)
> >>>  		return -ENODEV;
> >>>  	}
> >>>  
> >>> +	if (le32_to_cpu(pkt->hdr.dst_cid) == vsock->guest_cid) {
> >>> +		return virtio_transport_send_pkt_loopback(vsock, pkt);
> >>> +	}
> >>> +
> >> 
> >> A single-statement basic block should get surrounding curly
> >> braces.
> >> 
> > 
> > Should _not_ get curly braces in case it wasn't obvious ;)
> 
> Indeed, thanks for the correction :)

Thanks, I'll remember to run checkpatch.pl and send v2.

Stefan

Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)