netdev - Re: [PATCH net] tcp: zero ca_priv area when switching cc algorithms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161121.131423.1400416428808695997.davem@davemloft.net>
Date:   Mon, 21 Nov 2016 13:14:23 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     fw@...len.de
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] tcp: zero ca_priv area when switching cc algorithms

From: Florian Westphal <fw@...len.de>
Date: Mon, 21 Nov 2016 10:08:37 +0100

> We need to zero out the private data area when application switches
> connection to different algorithm (TCP_CONGESTION setsockopt).
> 
> When congestion ops get assigned at connect time everything is already
> zeroed because sk_alloc uses GFP_ZERO flag.  But in the setsockopt case
> this contains whatever previous cc placed there.
> 
> Signed-off-by: Florian Westphal <fw@...len.de>

Good catch, applied, thanks Florian.