netdev - Re: [PATCH] bnxt_en: Fix a VXLAN vs GENEVE issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLim17ZxiSrGe+TPR2pXDFrcNvZ=h-_xEbsJULiuVoOybbg@mail.gmail.com>
Date:   Mon, 21 Nov 2016 23:15:30 -0800
From:   Michael Chan <michael.chan@...adcom.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     David Miller <davem@...emloft.net>,
        Prashant Sreedharan <prashant.sreedharan@...adcom.com>,
        Netdev <netdev@...r.kernel.org>, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] bnxt_en: Fix a VXLAN vs GENEVE issue

On Mon, Nov 21, 2016 at 9:14 PM, Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
> Knowing that:
>   #define TUNNEL_DST_PORT_FREE_REQ_TUNNEL_TYPE_VXLAN        (0x1UL << 0)
>   #define TUNNEL_DST_PORT_FREE_REQ_TUNNEL_TYPE_GENEVE       (0x5UL << 0)
> and that 'bnxt_hwrm_tunnel_dst_port_alloc()' is only called with one of
> these 2 constants, the TUNNEL_DST_PORT_ALLOC_REQ_TUNNEL_TYPE_GENEVE can not
> trigger.
>
> Replace the bit test that overlap by an equality test, just as in
> 'bnxt_hwrm_tunnel_dst_port_free()' above.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Thanks.

Acked-by: Michael Chan <michael.chan@...adcom.com>