netdev - Re: [PATCH ethtool v3 2/2] Ethtool: Implements ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b8b7463f-0acc-fcfa-e3c0-251e8fdc24b8@gmail.com>
Date:   Mon, 21 Nov 2016 17:51:31 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     "Allan W. Nielsen" <allan.nielsen@...rosemi.com>,
        netdev@...r.kernel.org
Cc:     andrew@...n.ch, raju.lakkaraju@...rosemi.com
Subject: Re: [PATCH ethtool v3 2/2] Ethtool: Implements
 ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE and PHY downshift

On 11/17/2016 04:08 AM, Allan W. Nielsen wrote:
> From: Raju Lakkaraju <Raju.Lakkaraju@...rosemi.com>
> 
> Add ethtool get and set tunable to access PHY drivers.
> 
> Ethtool Help: ethtool -h for PHY tunables
>     ethtool --set-phy-tunable DEVNAME      Set PHY tunable
>                 [ downshift on|off [count N] ]
>     ethtool --get-phy-tunable DEVNAME      Get PHY tunable
>                 [ downshift ]
> 
> Ethtool ex:
>   ethtool --set-phy-tuanble eth0 downshift on
>   ethtool --set-phy-tuanble eth0 downshift off
>   ethtool --set-phy-tuanble eth0 downshift on count 2


s/tunable/tunable/

Since this will be used as examples for people testing this feature,
this is kind of important to get the example right ;)

Other than that:

Acked-by: Florian Fainelli <f.fainelli@...il.com>
Tested-by: Florian Fainelli <f.fainelli@...il.com>

> 
>   ethtool --get-phy-tunable eth0 downshift
> 
> Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@...rosemi.com>
> Signed-off-by: Allan W. Nielsen <allan.nielsen@...rosemi.com>
> ---

> +.B downshift
> +For operation in cabling environments that are incompatible with 1000BASE-T,
> +PHY device provides an automatic link speed downshift operation.

Might be worth mentioning that this is particularly useful if you are
using a cable which does not have the 4 pairs for instance.
-- 
Florian