netdev - Re: [PATCH ethtool] ethtool: Fix the "advertise" parameter logic.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161123150014.GB13179@tuxdriver.com>
Date:   Wed, 23 Nov 2016 10:00:14 -0500
From:   "John W. Linville" <linville@...driver.com>
To:     Michael Chan <michael.chan@...adcom.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH ethtool] ethtool: Fix the "advertise" parameter logic.

On Tue, Nov 22, 2016 at 06:55:47PM -0500, Michael Chan wrote:
> From: Michael Chan <mchan@...adcom.com>
> 
> The current code ignores the value of the advertise parameter.  For example,
> 
> ethtool -s ethx advertise 0x1000
> 
> The full_advertising_wanted parameter of 0x1000 is not passed to the kernel.
> The reason is that advertising_wanted is NULL in this case, and ethtool
> will think that the user has given no advertisement input and so it will
> proceed to pass all supported advertisement speeds to the kernel.
> 
> The older legacy ethtool with similar logic worked because
> advertising_wanted was an integer and could take on -1 and 0.  It would pass
> the full_advertising_wanted value if advertising_wanted == -1.
> 
> This fix is to pass all supported advertisement speeds only when both
> advertising_wanted == NULL && full_advertising_wanted == NULL.
> 
> Signed-off-by: Michael Chan <michael.chan@...adcom.com>

Thanks, Michael -- merging...

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.