netdev - Re: [PATCH] flowcache: Increase threshold for refusing new allocations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161123124255.GA3541@gauss.secunet.com>
Date:   Wed, 23 Nov 2016 13:42:55 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Miroslav Urbanek <mu@...oslavurbanek.com>
CC:     NetDev <netdev@...r.kernel.org>
Subject: Re: [PATCH] flowcache: Increase threshold for refusing new
 allocations

On Mon, Nov 21, 2016 at 03:48:21PM +0100, Miroslav Urbanek wrote:
> The threshold for OOM protection is too small for systems with large
> number of CPUs. Applications report ENOBUFs on connect() every 10
> minutes.
> 
> The problem is that the variable net->xfrm.flow_cache_gc_count is a
> global counter while the variable fc->high_watermark is a per-CPU
> constant. Take the number of CPUs into account as well.
> 
> Fixes: 6ad3122a08e3 ("flowcache: Avoid OOM condition under preasure")
> Reported-by: Lukáš Koldrt <lk@...ello.cz>
> Tested-by: Jan Hejl <jh@...ello.cz>
> Signed-off-by: Miroslav Urbanek <mu@...oslavurbanek.com>

Applied to the ipsec tree, thanks!