netdev - Re: [net-next PATCH v3] net: dummy: Introduce dummy virtual functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1479907588.8455.484.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Wed, 23 Nov 2016 05:26:28 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Phil Sutter <phil@....cc>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        Sabrina Dubroca <sd@...asysnail.net>
Subject: Re: [net-next PATCH v3] net: dummy: Introduce dummy virtual
 functions

On Wed, 2016-11-23 at 13:41 +0100, Phil Sutter wrote:

> +struct vf_data_storage {
> +	unsigned char vf_mac[ETH_ALEN];
> +	u16 pf_vlan; /* When set, guest VLAN config not allowed. */
> +	u16 pf_qos;
> +	__be16 vlan_proto;
> +	u16 min_tx_rate;
> +	u16 max_tx_rate;
> +	u8 spoofchk_enabled;
> +	bool rss_query_enabled;
> +	u8 trusted;
> +	int link_state;
> +};

Could you use proper indentation of field names ?

struct vf_data_storage {
	u8	vf_mac[ETH_ALEN];
	u16	pf_vlan; /* When set, guest VLAN config not allowed. */
	u16	pf_qos;
	__be16	vlan_proto;
	u16	min_tx_rate;
	u16	max_tx_rate;
	u8	spoofchk_enabled;
	bool	rss_query_enabled;
	u8	trusted;
	int	link_state;
};

struct dummy_priv {
	int			num_vfs;
	struct vf_data_storage	*vfinfo;
};

Thanks.