netdev - Re: [PATCH] cpsw: ethtool: add support for getting/setting EEE registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGm1_ks01zBoL_rVPbg=GqxLbm5X+pfvhbbL1X65+JFW2-2_Lw@mail.gmail.com>
Date:   Wed, 23 Nov 2016 15:40:32 +0100
From:   Yegor Yefremov <yegorslists@...glemail.com>
To:     Rami Rosen <roszenrami@...il.com>
Cc:     Netdev <netdev@...r.kernel.org>,
        Linux OMAP Mailing List <linux-omap@...r.kernel.org>,
        Grygorii Strashko <grygorii.strashko@...com>,
        "N, Mugunthan V" <mugunthanvnm@...com>
Subject: Re: [PATCH] cpsw: ethtool: add support for getting/setting EEE registers

Hi Rami,

On Wed, Nov 23, 2016 at 3:31 PM, Rami Rosen <roszenrami@...il.com> wrote:
> Hi, Yegor,
>
> Minor comment: these methods should be static.
>
> +int cpsw_get_eee(struct net_device *ndev, struct ethtool_eee *edata)
> +{
> ...
> ...
> +int cpsw_set_eee(struct net_device *ndev, struct ethtool_eee *edata)
> ...

ACK. Fixed in v2.

Thanks.

Yegor