netdev - Re: [PATCH v2] VSOCK: add loopback to virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161124.115400.234424564137643675.davem@davemloft.net>
Date:   Thu, 24 Nov 2016 11:54:00 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     stefanha@...hat.com
Cc:     netdev@...r.kernel.org, cavery@...hat.com,
        imbrenda@...ux.vnet.ibm.com, jhansen@...are.com
Subject: Re: [PATCH v2] VSOCK: add loopback to virtio_transport

From: Stefan Hajnoczi <stefanha@...hat.com>
Date: Mon, 21 Nov 2016 13:56:31 +0000

> The VMware VMCI transport supports loopback inside virtual machines.
> This patch implements loopback for virtio-vsock.
> 
> Flow control is handled by the virtio-vsock protocol as usual.  The
> sending process stops transmitting on a connection when the peer's
> receive buffer space is exhausted.
> 
> Cathy Avery <cavery@...hat.com> noticed this difference between VMCI and
> virtio-vsock when a test case using loopback failed.  Although loopback
> isn't the main point of AF_VSOCK, it is useful for testing and
> virtio-vsock must match VMCI semantics so that userspace programs run
> regardless of the underlying transport.
> 
> My understanding is that loopback is not supported on the host side with
> VMCI.  Follow that by implementing it only in the guest driver, not the
> vhost host driver.
> 
> Cc: Jorgen Hansen <jhansen@...are.com>
> Reported-by: Cathy Avery <cavery@...hat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@...hat.com>
> ---
> v2:
>  * Fixed checkpatch.pl warnings [DaveM]

Applied to net-next, thanks.