netdev - Re: [PATCH net-next] mlx4: reorganize struct mlx4_en_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161124.160413.361550700742982089.davem@davemloft.net>
Date:   Thu, 24 Nov 2016 16:04:13 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, tariqt@...lanox.com
Subject: Re: [PATCH net-next] mlx4: reorganize struct mlx4_en_tx_ring

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 22 Nov 2016 15:56:10 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Goal is to reorganize this critical structure to increase performance.
> 
> ndo_start_xmit() should only dirty one cache line, and access as few
> cache lines as possible.
> 
> Add sp_ (Slow Path) prefix to fields that are not used in fast path,
> to make clear what is going on.
> 
> After this patch pahole reports something much better, as all
> ndo_start_xmit() needed fields are packed into two cache lines instead
> of seven or eight
 ...
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.