netdev - Re: [PATCH 1/3] tools/virtio: fix READ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161124123402.4b3ef820.cornelia.huck@de.ibm.com>
Date:   Thu, 24 Nov 2016 12:34:02 +0100
From:   Cornelia Huck <cornelia.huck@...ibm.com>
To:     Mark Rutland <mark.rutland@....com>
Cc:     linux-kernel@...r.kernel.org, dave@...olabs.net, dbueso@...e.de,
        dvyukov@...gle.com, jasowang@...hat.com, kvm@...r.kernel.org,
        mst@...hat.com, netdev@...r.kernel.org, paulmck@...ux.vnet.ibm.com,
        virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH 1/3] tools/virtio: fix READ_ONCE()

On Thu, 24 Nov 2016 10:25:12 +0000
Mark Rutland <mark.rutland@....com> wrote:

> The virtio tools implementation of READ_ONCE() has a single parameter called
> 'var', but erroneously refers to 'val' for its cast, and thus won't work unless
> there's a variable of the correct type that happens to be called 'var'.
> 
> Fix this with s/var/val/, making READ_ONCE() work as expected regardless.
> 
> Fixes: a7c490333df3cff5 ("tools/virtio: use virt_xxx barriers")
> Signed-off-by: Mark Rutland <mark.rutland@....com>
> Cc: Jason Wang <jasowang@...hat.com>
> Cc: Michael S. Tsirkin <mst@...hat.com>
> Cc: linux-kernel@...r.kernel.org
> Cc: virtualization@...ts.linux-foundation.org
> ---
>  tools/virtio/linux/compiler.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Cornelia Huck <cornelia.huck@...ibm.com>