netdev - Re: [PATCH net-next v2] ethtool: Protect {get,set}_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161124114809.GG4457@microsemi.com>
Date:   Thu, 24 Nov 2016 12:48:10 +0100
From:   "Allan W. Nielsen" <allan.nielsen@...rosemi.com>
To:     Florian Fainelli <f.fainelli@...il.com>
CC:     <netdev@...r.kernel.org>, <davem@...emloft.net>,
        <bcm-kernel-feedback-list@...adcom.com>, <andrew@...n.ch>,
        <raju.lakkaraju@...rosemi.com>,
        <vivien.didelot@...oirfairelinux.com>
Subject: Re: [PATCH net-next v2] ethtool: Protect {get,set}_phy_tunable with
 PHY device mutex

On 22/11/16 13:55, Florian Fainelli wrote:
> EXTERNAL EMAIL
> 
> 
> PHY drivers should be able to rely on the caller of {get,set}_tunable to
> have acquired the PHY device mutex, in order to both serialize against
> concurrent calls of these functions, but also against PHY state machine
> changes. All ethtool PHY-level functions do this, except
> {get,set}_tunable, so we make them consistent here as well.
> 
> We need to update the Microsemi PHY driver in the same commit to avoid
> introducing either deadlocks, or lack of proper locking.
> 
> Fixes: 968ad9da7e0e ("ethtool: Implements ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE")
> Fixes: 310d9ad57ae0 ("net: phy: Add downshift get/set support in Microsemi PHYs driver")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
Reviewed-by: Allan W. Nielsen <allan.nielsen@...rosemi.com>