netdev - RE: [PATCH net v2 4/5] net: fsl/fman: fix fixed-link-phydev reference leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM4PR04MB16041ACDCDACF188B37E61F6EC890@AM4PR04MB1604.eurprd04.prod.outlook.com>
Date:   Fri, 25 Nov 2016 10:54:27 +0000
From:   Madalin-Cristian Bucur <madalin.bucur@....com>
To:     Johan Hovold <johan@...nel.org>,
        "David S. Miller" <davem@...emloft.net>
CC:     Florian Fainelli <f.fainelli@...il.com>,
        Timur Tabi <timur@...eaurora.org>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net v2 4/5] net: fsl/fman: fix fixed-link-phydev reference
 leak

> -----Original Message-----
> From: Johan Hovold [mailto:jhovold@...il.com] On Behalf Of Johan Hovold
> Sent: Thursday, November 24, 2016 8:22 PM
> 
> Make sure to drop the reference taken by of_phy_find_device() when
> looking up a fixed-link phydev during probe.
> 
> Fixes: 57ba4c9b56d8 ("fsl/fman: Add FMan MAC support")
> Signed-off-by: Johan Hovold <johan@...nel.org>
> ---
>  drivers/net/ethernet/freescale/fman/mac.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/freescale/fman/mac.c
> b/drivers/net/ethernet/freescale/fman/mac.c
> index 8fe6b3e253fa..736db9d9b0ad 100644
> --- a/drivers/net/ethernet/freescale/fman/mac.c
> +++ b/drivers/net/ethernet/freescale/fman/mac.c
> @@ -892,6 +892,8 @@ static int mac_probe(struct platform_device *_of_dev)
>  		priv->fixed_link->duplex = phy->duplex;
>  		priv->fixed_link->pause = phy->pause;
>  		priv->fixed_link->asym_pause = phy->asym_pause;
> +
> +		put_device(&phy->mdio.dev);
>  	}
> 
>  	err = mac_dev->init(mac_dev);
> --
> 2.7.3

Thank you,
Madalin