netdev - Re: [PATCH RFC v1] ethtool: implement helper to get flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161125.160634.944615331208897862.davem@davemloft.net>
Date:   Fri, 25 Nov 2016 16:06:34 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jacob.e.keller@...el.com
Cc:     netdev@...r.kernel.org, intel-wired-lan@...ts.osuosl.org
Subject: Re: [PATCH RFC v1] ethtool: implement helper to get flow_type value

From: Jacob Keller <jacob.e.keller@...el.com>
Date: Tue, 22 Nov 2016 15:44:53 -0800

> @@ -880,6 +880,14 @@ struct ethtool_rx_flow_spec {
>  	__u32		location;
>  };
>  
> +/* Flag to enable additional fields in struct ethtool_rx_flow_spec */
> +#define	FLOW_EXT	0x80000000
> +#define	FLOW_MAC_EXT	0x40000000
> +static inline __u32 ethtool_get_flow_spec_type(__u32 flow_type)
> +{
> +	return flow_type & (FLOW_EXT | FLOW_MAC_EXT);
> +}
> +
>  /* How rings are layed out when accessing virtual functions or
>   * offloaded queues is device specific. To allow users to do flow
>   * steering and specify these queues the ring cookie is partitioned
> @@ -1579,9 +1587,6 @@ static inline int ethtool_validate_duplex(__u8 duplex)
>  #define	IPV4_FLOW	0x10	/* hash only */
>  #define	IPV6_FLOW	0x11	/* hash only */
>  #define	ETHER_FLOW	0x12	/* spec only (ether_spec) */
> -/* Flag to enable additional fields in struct ethtool_rx_flow_spec */
> -#define	FLOW_EXT	0x80000000
> -#define	FLOW_MAC_EXT	0x40000000
>  
>  /* L3-L4 network traffic flow hash options */
>  #define	RXH_L2DA	(1 << 1)

Please put the helper after the FLOW_* definitions rather than moving
them earlier in the file.