netdev - Re: [PATCH 3/8] irda: w83977af_ir: Remove unnecessary blank lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea272463-7af8-87d5-235c-631d280714b9@cogentembedded.com>
Date:   Fri, 25 Nov 2016 13:31:50 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Joe Perches <joe@...ches.com>, Samuel Ortiz <samuel@...tiz.org>
Cc:     Arnd Bergmann <arnd@...db.de>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/8] irda: w83977af_ir: Remove unnecessary blank lines

Hello.

On 11/24/2016 10:10 PM, Joe Perches wrote:

> These just add unnecessary vertical whitespace.
>
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/net/irda/w83977af_ir.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c
> index 4ad91f4f867f..5aa61413aea8 100644
> --- a/drivers/net/irda/w83977af_ir.c
> +++ b/drivers/net/irda/w83977af_ir.c
[...]
> @@ -553,6 +552,7 @@ static netdev_tx_t w83977af_hard_xmit(struct sk_buff *skb,
>  static void w83977af_dma_write(struct w83977af_ir *self, int iobase)
>  {
>  	__u8 set;
> +
>  	pr_debug("%s(), len=%d\n", __func__, self->tx_buff.len);
>
>  	/* Save current set */

    Removing, really? :-)

MBR, Sergei