netdev - Re: [PATCH v2 net] phy: fix error case of phy_led_triggers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Nov 2016 19:59:27 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     Woojung.Huh@...rochip.com
Cc:     zach.brown@...com, netdev@...r.kernel.org, f.fainelli@...il.com,
        andrew@...n.ch
Subject: Re: [PATCH v2 net] phy: fix error case of
 phy_led_triggers_(un)register

From: <Woojung.Huh@...rochip.com>
Date: Wed, 23 Nov 2016 23:10:33 +0000

> From: Woojung Huh <woojung.huh@...rochip.com>
> 
> When phy_init_hw() fails at phy_attach_direct();
> - phy_detach() calls phy_led_triggers_unregister() without
>   previous call of phy_led_triggers_register().
> - still call phy_led_triggers_register() and cause memory leak.
> 
> Fixes: 2e0bc452f472 ("net: phy: leds: add support for led triggers on phy link state change")
> Signed-off-by: Woojung Huh <woojung.huh@...rochip.com>

Applied to net-next.