netdev - Re: [PATCH] netdevice: fix sparse warning for HARD_TX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161127.154439.845919200540679482.davem@davemloft.net>
Date:   Sun, 27 Nov 2016 15:44:39 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     mst@...hat.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] netdevice: fix sparse warning for HARD_TX_LOCK

From: "Michael S. Tsirkin" <mst@...hat.com>
Date: Thu, 24 Nov 2016 07:04:08 +0200

> sparse warns about context imbalance in any code
> that uses HARD_TX_LOCK/UNLOCK - this is because it's
> unable to determine that flags don't change so
> lock and unlock are paired.
> 
> Seems easy enough to fix by adding __acquire/__release
> calls.
> 
> With this patch af_packet.c is now sparse-clean,
> 
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>

Applied to net-next, thanks.